Wow, that was quick, although I already implemented a Gimatriya code to convert the year from hdate field :D
Regarding changing the API:
On automated systems this is considered a breaking change (if a validation is done on the returned structure, now it has an unexpected new field). I would, at least, control adding this new field via query params and not automatically. (like &fields[]=category&fields[]=hebrew&fields[]=heDateParts, and if fields query param is omitted just return some default fields).
Just my 2 cents.
Thanks, I'm going to look at it and also take a look at the JS package.
Wow, that was quick, although I already implemented a Gimatriya code to convert the year from
hdate
field :DRegarding changing the API:
On automated systems this is considered a breaking change (if a validation is done on the returned structure, now it has an unexpected new field). I would, at least, control adding this new field via query params and not automatically. (like
&fields[]=category&fields[]=hebrew&fields[]=heDateParts
, and iffields
query param is omitted just return some default fields).Just my 2 cents.
Thanks, I'm going to look at it and also take a look at the JS package.